C#: Fully qualified name. #15887
Merged
C#: Fully qualified name. #15887
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelnebel
force-pushed
the
csharp/qualifiedname
branch
from
bb3df9f to
15ae64f
Compare
michaelnebel
force-pushed
the
csharp/qualifiedname
branch
from
3d85686 to
8093e28
Compare
michaelnebel
added
the
no-change-note-required
|
DCA looks good. |
hvitved
reviewed
Apr 8, 2024
michaelnebel
force-pushed
the
csharp/qualifiedname
branch
from
8093e28 to
fc689ef
Compare
hvitved
reviewed
Apr 8, 2024
csharp/ql/integration-tests/all-platforms/diag_recursive_generics/Types.ql
Outdated
Show resolved
Hide resolved
hvitved
approved these changes
Apr 9, 2024
|
Running DCA again, just to be on the safe side. |
|
DCA looks good! 55% string cache reduction. |
😮 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we replace the last uses of
getFullyQualifiedNameandgetFullyQualifiedNameWithTypes(and deprecate and uncache these) with theirhasFully..counterparts to avoid unneeded string concatenation (and thus pressure on the string pool).Further more we delete some of the deprecated caches predicates.