Ruby: Model ActiveDispatch::Http::UploadedFile #15907
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joefarebrother
force-pushed
the
ruby-uploaded-file
branch
from
0692cee to
f464f1b
Compare
joefarebrother
changed the title
hvitved
force-pushed
the
ruby-uploaded-file
branch
from
84cb919 to
e7b00a7
Compare
alexrford
suggested changes
Mar 15, 2024
Comment on lines
+513
to
+514
| paramsInstance(), | ||
| paramsInstance().getAMethodCall(methodReturnsTaintFromSelf()).getAnElementRead*() |
There was a problem hiding this comment.
This is probably a bit broader than it needs to be, as it will include field accesses like params[:foo] and params.dig(:foo, :bar, :baz), but also other things like hashes and arrays that are tainted by request parameters (e.g. params, params.deep_dup(), params.values_at(:a, :b)).
This should work fine in practice, but the name and documentation is misleading - this is really describing anything that might be tainted by params in a way that our standard taint tracking might not detect.
alexrford
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR models attributes and methods from an
UploadedFilethat comes from a field ofparams.This allows an additional result for command injection in railsgoat to be found.
Closes https://github.com/github/codeql-team/issues/2363.