Skip to content

C++: suppress destructors with reuse expressions until proper support is added #15908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

jketema
Copy link
Contributor

@jketema jketema commented Mar 13, 2024

Final preparatory PR on the QL-side for the destructors of unnamed entities work. All that remains after this are test updates.

Do we need to make explicit in our internal tracking issue that the case where the destruction happens at the statement level should also be addressed?

@jketema jketema added the no-change-note-required This PR does not need a change note label Mar 13, 2024
@github-actions github-actions bot added the C++ label Mar 13, 2024
@jketema jketema marked this pull request as ready for review March 13, 2024 19:25
@jketema jketema requested a review from a team as a code owner March 13, 2024 19:25
Copy link
Contributor

@MathiasVP MathiasVP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if DCA is happy!

@jketema jketema merged commit b2e0485 into github:main Mar 14, 2024
@jketema jketema deleted the destructors12 branch March 14, 2024 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C++ no-change-note-required This PR does not need a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants