CPP: Add test coverage for LeapYearFieldAccess.isModifiedByArithmeticOperation. #1594
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…whether the return value of the time conversion function is checked.
|
I've added another test showing that Adding365daysPerYear.ql doesn't quite work as advertised re: requiring the time conversion function being unchecked. I'm inclined not to worry about fixing this unless/until we see false positives in the wild, as currently the query does not produce many results total so FPs will be very rare. |
jbj
reviewed
Aug 8, 2019
cpp/ql/test/query-tests/Likely Bugs/Leap Year/Adding365DaysPerYear/test.cpp
Outdated
Show resolved
Hide resolved
cpp/ql/test/query-tests/Likely Bugs/Leap Year/UncheckedLeapYearAfterYearModification/test.cpp
Outdated
Show resolved
Hide resolved
jbj
approved these changes
Aug 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add test coverage for
LeapYearFieldAccess.isModifiedByArithmeticOperation(), which previously could be replaced byany()without causing any test failures. I've also convinced myself that my concerns at #1354 (comment) (never replied to) were unfounded.