Python points-to: Remove negative recursion when using legacy points-to extensions #1609
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to in legacy points-to extensions.
markshannon
force-pushed
the
python-better-points-to-extensions
branch
from
54557ec to
c6ae06f
Compare
taus-semmle
suggested changes
Jul 18, 2019
taus-semmle
approved these changes
Jul 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows legacy points-to extensions to work with the new points-to implementation.
Replaces
ObjectInternal.isMissing()withObjectInternal.useOriginAsLegacyObject()to avoid negation.https://github.com/Semmle/ql/pull/1609/files#diff-a1c546926c2c8e21b32497dd0ae4c354R133 and https://github.com/Semmle/ql/pull/1609/files#diff-a1c546926c2c8e21b32497dd0ae4c354R148 are where the negative recursion is removed.