Data flow: Block flow at expectsContents nodes in parameterValueFlow
#16110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| * `reverse` does not get picked up by the `reverseStepThroughInputOutputAlias` | ||
| * logic in `DataFlowImplCommon.qll`. | ||
| */ | ||
| query predicate noReverseStepThroughInputOutputAlias(DataFlow::Node source, DataFlow::Node sink) { |
Check warning
Code scanning / CodeQL
Missing QLDoc for parameter Warning
hvitved
force-pushed
the
dataflow/param-flow-no-expects-content
branch
from
c5117cd
to
5cc9fbb
Compare
hvitved
force-pushed
the
dataflow/param-flow-no-expects-content
branch
from
5cc9fbb
to
7871fb8
Compare
aschackmull
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
expectsContentsnodes as barriers inparameterValueFlow, just like we already do inrevLambdaFlow. Otherwise, we can end up generating spurious local flow steps viareverseStepThroughInputOutputAlias, as documented with a Ruby test on this PR.DCA is uneventful, except for a significant speedup on the Ruby project
rapid7__metasploit-framework.