Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python: Various extractor fixups #16112

Merged
merged 4 commits into from
Apr 9, 2024
Merged

Conversation

tausbn
Copy link
Contributor

@tausbn tausbn commented Apr 3, 2024

Two minor fixes relating to our build process, as well as removing the stripping of comments and docstrings when building the extractor.

Best reviewed commit-by-commit.

@tausbn tausbn added the no-change-note-required This PR does not need a change note label Apr 3, 2024
The latter makes more sense, as it's actually building
`tree-sitter-python`.
This aligns us better with the corresponding instructions for
the Ruby extractor.
@tausbn tausbn force-pushed the tausbn/python-various-extractor-fixups branch from 9f150aa to ef9f99b Compare April 5, 2024 10:30
@tausbn tausbn marked this pull request as ready for review April 5, 2024 11:04
@tausbn tausbn requested a review from a team as a code owner April 5, 2024 11:04
Copy link
Member

@RasmusWL RasmusWL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@RasmusWL RasmusWL merged commit 6ce38be into main Apr 9, 2024
10 checks passed
@RasmusWL RasmusWL deleted the tausbn/python-various-extractor-fixups branch April 9, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation no-change-note-required This PR does not need a change note Python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants