Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C#: Avoid process creation indirection in auto-builder #16134

Merged

Conversation

hvitved
Copy link
Contributor

@hvitved hvitved commented Apr 5, 2024

Invoke the buildless extractor directly in --build-mode none instead of through a process creation.

@github-actions github-actions bot added the C# label Apr 5, 2024
@hvitved hvitved force-pushed the csharp/autobuild-buildless-process-indirection branch 2 times, most recently from 78a4d48 to fb33755 Compare April 8, 2024 09:16
@hvitved
Copy link
Contributor Author

hvitved commented Apr 8, 2024

This PR is currently blocked by the tracer needing to be disabled in --build-mode none (cc @henrymercer ).

@hvitved hvitved force-pushed the csharp/autobuild-buildless-process-indirection branch from fb33755 to c10a97d Compare May 21, 2024 11:51
@hvitved hvitved added the no-change-note-required This PR does not need a change note label May 22, 2024
@hvitved hvitved marked this pull request as ready for review May 22, 2024 08:49
@hvitved hvitved requested a review from a team as a code owner May 22, 2024 08:49
@hvitved hvitved force-pushed the csharp/autobuild-buildless-process-indirection branch from c10a97d to c29e16d Compare May 22, 2024 09:45
@hvitved hvitved added the depends on internal PR This PR should only be merged in sync with an internal Semmle PR label May 22, 2024
@hvitved hvitved force-pushed the csharp/autobuild-buildless-process-indirection branch from c29e16d to 0ce569d Compare May 22, 2024 12:12
@hvitved hvitved force-pushed the csharp/autobuild-buildless-process-indirection branch from 0ce569d to 621de2b Compare May 22, 2024 18:05
@hvitved hvitved merged commit 11da42b into github:main May 23, 2024
16 checks passed
@hvitved hvitved deleted the csharp/autobuild-buildless-process-indirection branch May 23, 2024 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C# depends on internal PR This PR should only be merged in sync with an internal Semmle PR no-change-note-required This PR does not need a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants