Skip to content

Data flow: Fix a bad join #16251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 19, 2024
Merged

Data flow: Fix a bad join #16251

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion shared/dataflow/codeql/dataflow/internal/DataFlowImpl.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4469,6 +4469,12 @@ module MakeImpl<LocationSig Location, InputSig<Location> Lang> {
)
}

bindingset[par, ret]
pragma[inline_late]
private predicate summaryCtxStepStar(PathNodeImpl par, PathNodeImpl ret) {
summaryCtxStep*(par) = ret
}

/**
* Holds if `(arg, par, ret, out)` forms a subpath-tuple.
*
Expand All @@ -4483,7 +4489,7 @@ module MakeImpl<LocationSig Location, InputSig<Location> Lang> {
any(PathNodeImpl n | localStepToHidden*(ret, n)), out) and
not par.isHidden() and
not ret.isHidden() and
ret = summaryCtxStep*(par)
summaryCtxStepStar(par, ret)
or
// wrapped subpath using hidden nodes, e.g. flow through a callback inside
// a summarized callable
Expand Down