Skip to content

C++: Improve handling of re-use expressions #16289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 22, 2024
Merged

C++: Improve handling of re-use expressions #16289

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2c76b13
C++: Improve handling of re-used qualifier in delete expressions
jketema Apr 19, 2024
bcde715
C++: Address review comment
jketema Apr 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 1 addition & 11 deletions cpp/ql/lib/semmle/code/cpp/exprs/Expr.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1371,17 +1371,7 @@ class ReuseExpr extends Expr, @reuseexpr {
/**
* Gets the expression that is being re-used.
*/
Expr getReusedExpr() {
// In the case of a prvalue, the extractor outputs the expression
// before conversion, but the converted expression is intended.
if this.isPRValueCategory()
then result = this.getBaseReusedExpr().getFullyConverted()
else result = this.getBaseReusedExpr()
}

private Expr getBaseReusedExpr() {
expr_reuse(underlyingElement(this), unresolveElement(result), _)
}
Expr getReusedExpr() { expr_reuse(underlyingElement(this), unresolveElement(result), _) }

override Type getType() { result = this.getReusedExpr().getType() }

Expand Down