Skip to content

C#: Fix a bad join #16304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 24, 2024
Merged

C#: Fix a bad join #16304

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6aa4c5c
C#: Fix a bad join
hvitved Apr 23, 2024
d8d7688
C#: Fix another bad join
hvitved Apr 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 14 additions & 6 deletions csharp/ql/src/Security Features/CWE-352/MissingAntiForgeryTokenValidation.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,21 @@ import semmle.code.csharp.frameworks.system.Web
import semmle.code.csharp.frameworks.system.web.Helpers
import semmle.code.csharp.frameworks.system.web.Mvc

private Method getAValidatingMethod() {
result = any(AntiForgeryClass a).getValidateMethod()
or
result.calls(getAValidatingMethod())
}

/** An `AuthorizationFilter` that calls the `AntiForgery.Validate` method. */
class AntiForgeryAuthorizationFilter extends AuthorizationFilter {
AntiForgeryAuthorizationFilter() {
this.getOnAuthorizationMethod().calls*(any(AntiForgeryClass a).getValidateMethod())
}
AntiForgeryAuthorizationFilter() { this.getOnAuthorizationMethod() = getAValidatingMethod() }
}

private Method getAStartedMethod() {
result = any(WebApplication wa).getApplication_StartMethod()
or
getAStartedMethod().calls(result)
}

/**
Expand All @@ -34,9 +44,7 @@ predicate hasGlobalAntiForgeryFilter() {
// The filter is an antiforgery filter
addGlobalFilter.getArgumentForName("filter").getType() instanceof AntiForgeryAuthorizationFilter and
// The filter is added by the Application_Start() method
any(WebApplication wa)
.getApplication_StartMethod()
.calls*(addGlobalFilter.getEnclosingCallable())
getAStartedMethod() = addGlobalFilter.getEnclosingCallable()
)
}

Expand Down