C++: Clean up IRVariables using final aliases
#16415
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…as'ing to ensure that we don't accidentially extend the abstract base class.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -17,18 +17,11 @@ | |||
| * The variable may be a user-declared variable (`IRUserVariable`) or a temporary variable generated | |||
| * by the AST-to-IR translation (`IRTempVariable`). | |||
| */ | |||
| class IRVariable extends TIRVariable { | |||
| abstract private class AbstractIRVariable extends TIRVariable { | |||
Check warning
Code scanning / CodeQL
UnusedField
| @@ -17,18 +17,11 @@ | |||
| * The variable may be a user-declared variable (`IRUserVariable`) or a temporary variable generated | |||
| * by the AST-to-IR translation (`IRTempVariable`). | |||
| */ | |||
| class IRVariable extends TIRVariable { | |||
| abstract private class AbstractIRVariable extends TIRVariable { | |||
Check warning
Code scanning / CodeQL
UnusedField
jketema
approved these changes
May 3, 2024
|
DCA was uneventful (as expected) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is just a simple refactoring of the
IRVariablefiles that replaces explicit enumeration of subclasses in the base class with abstract classes.In order to ensure no other code accidentally extends the new abstract classes they're kept private and final aliases are provided. This means code will continue to work exactly as before.