Skip to content

Swift: Remove beta label #16502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 15, 2024
Merged

Swift: Remove beta label #16502

merged 6 commits into from
Jul 15, 2024

Conversation

MathiasVP
Copy link
Contributor

No description provided.

@MathiasVP MathiasVP changed the title Remove Swift beta label Swift: Remove beta label May 15, 2024
@MathiasVP MathiasVP force-pushed the MathiasVP-patch-1 branch from 1834611 to 8f15b0b Compare May 15, 2024 21:54
@MathiasVP MathiasVP requested a review from a team as a code owner May 15, 2024 21:56
@github-actions github-actions bot added the Swift label May 15, 2024
geoffw0
geoffw0 requested changes May 16, 2024
View reviewed changes
Copy link
Contributor

@geoffw0 geoffw0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@MathiasVP MathiasVP marked this pull request as draft May 16, 2024 10:20
@geoffw0
Copy link
Contributor

geoffw0 commented Jul 11, 2024

It's time I gave this a proper review:

  • I'm happy that you've removed all the Swift beta references from this repository correctly.
    • there's a discussion going on elsewhere about references that may exist in other repos.
  • I've made a PR onto this PR to add a change note, using the same wording as for Kotlin.

geoffw0
geoffw0 previously approved these changes Jul 11, 2024
View reviewed changes
Copy link
Contributor

@geoffw0 geoffw0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and can come out of draft. I'm currently in a conversation about when we want to merge this / what else might need to be merged at the same time.

@MathiasVP MathiasVP marked this pull request as ready for review July 11, 2024 15:10
@felicitymay felicitymay added the ready-for-doc-review This PR requires and is ready for review from the GitHub docs team. label Jul 12, 2024
felicitymay
felicitymay previously approved these changes Jul 15, 2024
View reviewed changes
Copy link
Contributor

@felicitymay felicitymay left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR. The changes look great 👍🏻

As for the similar PR for Kotlin GA, my only question is whether or not we want to merge into main and publish these changes with the next release of CodeQL CLI, or whether we want to publish the changes sooner (in which case merging into the 2.18.0 branch would make publication simpler).

I just had confirmation that merging into main is fine 🚀

@MathiasVP MathiasVP dismissed stale reviews from felicitymay and geoffw0 via 29e9c05 July 15, 2024 12:28
@MathiasVP
Copy link
Contributor Author

@geoffw0 @felicitymay I had to fix a couple of conflicts. Do you mind reapproving this so that we can get this across the finish line? 🚀

@MathiasVP MathiasVP merged commit 1c33698 into main Jul 15, 2024
12 checks passed
@MathiasVP MathiasVP deleted the MathiasVP-patch-1 branch July 15, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoffw0 geoffw0 geoffw0 approved these changes

@felicitymay felicitymay felicitymay left review comments

Assignees
No one assigned
Labels
documentation ready-for-doc-review This PR requires and is ready for review from the GitHub docs team. Swift
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MathiasVP @geoffw0 @felicitymay