C#: Change the printed information in the Flow summaries tests. #16513
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelnebel
added
the
no-change-note-required
tamasvajk
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we remove the "override" and "ext" column of the printed summary information in the tests. The "override" information is merely a best guess as it was and cause more confusion than value. The "ext" column was hardcoded to empty.
There is a small discrepancy (reduction of the number of lines in the expected files). This is because some rows where two distinct callables with the same signature (in terms of models as data) are present in the same class.
An examples of this is
CreateEscapedIdentifierin https://github.com/dotnet/runtime/blob/044e9d3511ff163ae8606968115f5f7b362ae9cd/src/libraries/System.CodeDom/src/System/CodeDom/Compiler/CodeGenerator.csThere is both an explicit interface implementation and an abstract method named
CreateEscapedIdentifierwe do not distinguish these when printing the signature.