Kotlin: Accept Kotlin 2 test output, and use 2.0.0 on CI #16554
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igfoo
force-pushed
the
igfoo/k2rel
branch
2 times, most recently
from
38767e8 to
47c984f
Compare
igfoo
force-pushed
the
igfoo/k2rel
branch
2 times, most recently
from
df40898 to
e8071eb
Compare
tamasvajk
reviewed
Jun 3, 2024
It needs some changes in the internal repo too; all tests are passing on the accompanying PR there. |
tamasvajk
approved these changes
Jun 3, 2024
The top comment now gets owned by the Compilation Unit. We could explicitly stop this from happening instead, but I think it's reasonable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some tests now explicitly use 1.9 mode; I've opened a ticket to look into what happens with those in 2.0 mode.
Some of the test changes in the Kotlin 2 testsuite are regressions (with accompanying bugs filed upstream), but we need to accept them for now so that we can run the testsuite and spot future changes.