Skip to content

C#: Simplify logic in JsonWebTokenHandlerLib.qll #16559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 23, 2024

Conversation

hvitved
Copy link
Contributor

@hvitved hvitved commented May 22, 2024

Generalized CallableAlwaysReturnsTrue for lambdas. Also removed CallableAlwaysReturnsTrueHigherPrecision, since the supposed extra callableOnlyThrowsArgumentNullException(this) condition is already imposed in CallableAlwaysReturnsTrue.

@github-actions github-actions bot added the C# label May 22, 2024
@hvitved hvitved added the no-change-note-required This PR does not need a change note label May 22, 2024
@hvitved hvitved marked this pull request as ready for review May 22, 2024 13:28
@hvitved hvitved requested a review from a team as a code owner May 22, 2024 13:28
Copy link
Contributor

@michaelnebel michaelnebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hvitved hvitved merged commit f517c00 into github:main May 23, 2024
@hvitved hvitved deleted the csharp/callable-always-returns-true branch May 23, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C# no-change-note-required This PR does not need a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants