Skip to content

C#: Add support for flow through side-effects on static fields #16576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 13, 2024

Conversation

hvitved
Copy link
Contributor

@hvitved hvitved commented May 23, 2024

Same as #16500 for Java.

aschackmull
aschackmull previously approved these changes May 23, 2024
Copy link
Contributor

@aschackmull aschackmull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but be sure to check dca before merging.

@hvitved hvitved force-pushed the csharp/static-field-side-effect branch from 34923bf to 1bcac50 Compare August 12, 2024 08:02
@hvitved hvitved marked this pull request as ready for review August 13, 2024 10:10
@hvitved hvitved requested a review from a team as a code owner August 13, 2024 10:10
Copy link
Contributor

@michaelnebel michaelnebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hvitved hvitved merged commit 3395dc9 into github:main Aug 13, 2024
22 checks passed
@hvitved hvitved deleted the csharp/static-field-side-effect branch August 13, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants