Skip to content

Java: Add more File-related sinks to the path-injection query #16600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 4, 2024

Conversation

atorralba
Copy link
Contributor

No description provided.

@atorralba atorralba requested a review from a team as a code owner May 27, 2024 13:19
Copy link
Contributor

github-actions bot commented May 27, 2024

⚠️ The head of this PR and the base branch were compared for differences in the framework coverage reports. The generated reports are available in the artifacts of this workflow run. The differences will be picked up by the nightly job after the PR gets merged.

Click to show differences in coverage

java

Generated file changes for java

  • Changes to framework-coverage-java.rst:
-    Java Standard Library,``java.*``,10,4267,240,80,,9,,,26
+    Java Standard Library,``java.*``,10,4267,255,95,,9,,,26
-    Totals,,310,25130,2569,338,16,128,33,1,409
+    Totals,,310,25130,2584,353,16,128,33,1,409
  • Changes to framework-coverage-java.csv:
- java.io,51,1,256,,,,,,,,,22,,,,,,,,,,,,,,,29,,,,,,,,,,,,,,,,,,,,,,1,,249,7
+ java.io,66,1,256,,,,,,,,,22,,,,,,,,,,,,,,,44,,,,,,,,,,,,,,,,,,,,,,1,,249,7

@atorralba atorralba force-pushed the atorralba/java/more-file-sinks branch from b47c582 to 4dd7772 Compare May 27, 2024 13:43
---
category: minorAnalysis
---
* Added more `File`-related sinks to the path injection query.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mention it's java.io.File

owen-mc
owen-mc previously approved these changes May 27, 2024
@atorralba atorralba force-pushed the atorralba/java/more-file-sinks branch from 23247e1 to 3cffeba Compare May 28, 2024 15:54
owen-mc
owen-mc previously approved these changes May 28, 2024
@owen-mc
Copy link
Contributor

owen-mc commented May 31, 2024

more test failures

@atorralba atorralba added the depends on internal PR This PR should only be merged in sync with an internal Semmle PR label Jun 3, 2024
@atorralba
Copy link
Contributor Author

more test failures

See backref for internal PR fixing the internal tests.

@atorralba atorralba force-pushed the atorralba/java/more-file-sinks branch from 9a945b2 to 0f904b7 Compare June 3, 2024 08:01
Copy link
Contributor

@smowton smowton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Proxying Owen's review on related PR

@atorralba atorralba force-pushed the atorralba/java/more-file-sinks branch from 0f904b7 to 292395b Compare June 4, 2024 08:35
@atorralba atorralba merged commit 78552b8 into github:main Jun 4, 2024
@atorralba atorralba deleted the atorralba/java/more-file-sinks branch June 4, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
depends on internal PR This PR should only be merged in sync with an internal Semmle PR documentation Java
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants