Skip to content

Conversation

owen-mc
Copy link
Contributor

@owen-mc owen-mc commented May 29, 2024

This was based on the equivalent for java (except most of the go tests fail).

@owen-mc owen-mc requested a review from a team as a code owner May 29, 2024 15:15
@github-actions github-actions bot added the Go label May 29, 2024
import TestUtilities.InlineFlowTest

string getArgString(DataFlow::Node src, DataFlow::Node sink) {
exists(src) and

Check warning

Code scanning / CodeQL

Superfluous 'exists' conjunct.

This conjunct is superfluous as the existence is implied by [this conjunct](1).
Copy link
Contributor

@aschackmull aschackmull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test looks good and nicely comprehensive to me.

@owen-mc owen-mc merged commit 61593ae into github:main May 30, 2024
@owen-mc owen-mc deleted the go/side-effects-on-global-variables branch May 30, 2024 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants