Skip to content

Tree-sitter: Verbosity fixes #16636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 4, 2024
Merged

Tree-sitter: Verbosity fixes #16636

merged 1 commit into from
Jun 4, 2024

Conversation

hvitved
Copy link
Contributor

@hvitved hvitved commented May 31, 2024 •
edited
Loading

  1. Make sure that the auto-builder passes the verbosity defined in CODEQL_VERBOSITY into the codeql database index-files invocation.
  2. Make sure that the verbosity applies to the shared logic in the codeql-extractor crate.

@hvitved hvitved force-pushed the tree-sitter/verbosity-fix branch from c4a3728 to 1786ae5 Compare May 31, 2024 11:33
@github-actions github-actions bot added the Ruby label May 31, 2024
@hvitved hvitved added the no-change-note-required This PR does not need a change note label May 31, 2024
@hvitved hvitved marked this pull request as ready for review May 31, 2024 12:45
@hvitved hvitved requested a review from a team as a code owner May 31, 2024 12:45
aibaars
aibaars previously approved these changes May 31, 2024
View reviewed changes
Copy link
Contributor

@aibaars aibaars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me . One minor comment, feel free to ignore if you disagree

ruby/extractor/src/extractor.rs Outdated
@@ -26,6 +26,7 @@ pub struct Options {

pub fn run(options: Options) -> std::io::Result<()> {
extractor::set_tracing_level("ruby");
tracing::info!("Starting extraction");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps "Extraction started" to match the style of the log message at the end.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks; I have updated the message.

@hvitved hvitved force-pushed the tree-sitter/verbosity-fix branch from 1786ae5 to beeae69 Compare May 31, 2024 18:10
@hvitved hvitved merged commit e6dc36b into github:main Jun 4, 2024
@hvitved hvitved deleted the tree-sitter/verbosity-fix branch June 4, 2024 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aibaars aibaars aibaars approved these changes

Assignees
No one assigned
Labels
no-change-note-required This PR does not need a change note Ruby
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hvitved @aibaars