Extract .xsaccess files as JSON #16675
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erik-krogh
reviewed
Jun 4, 2024
| @@ -182,6 +182,7 @@ public void basicTest() throws IOException { | |||
| addFile(true, LGTM_SRC, "package.json"); | |||
| addFile(true, LGTM_SRC, ".eslintrc.yml"); | |||
| addFile(true, LGTM_SRC, "vendor", "leftpad", "index.js"); | |||
| addFile(true, LGTM_SRC, ".xsaccess"); | |||
There was a problem hiding this comment.
The tests are still failing. I suspect this line needs to be removed.
There was a problem hiding this comment.
Now it passes but I do not see in the logs any evidence that the extraction actually happened
There was a problem hiding this comment.
The trap file you added shows that the extraction happened.
The trap tests is another way of testing the extractor.
erik-krogh
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The JavaScript extractor now extracts SAP HANA
.xsaccessfiles as JSON.