Go: Refactor queries to use ThreatModelFlowSource instead of RemoteFlowSource
#16709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egregius313
force-pushed
the
egregius313/go/df/threat-models/refactor-queries
branch
from
b4d4f82
to
2d2eff7
Compare
owen-mc
previously approved these changes
Jun 11, 2024
| --- | ||
| category: minorAnalysis | ||
| --- | ||
| * The `Customizations` libraries for several queries, as well as queries which do not have `Customizations` libraries, have been modified to use `ThreatModelFlowSource` to define their `isSource` predicates instead of `RemoteFlowSource`. This means these queries will now respect threat model configurations. |
There was a problem hiding this comment.
- I don't think it's worth distinguishing between queries with customization libraries and those without. Most users won't know the difference, and those that do can easily verify that both have been updated.
- I think it's worth explaining briefly that
ThreatModelFlowSourcewill be the same asRemoteFlowSourceexcept when the query is run in the presence of a specified threat model.
|
You should probably do a DCA run before merging as well. |
egregius313
force-pushed
the
egregius313/go/df/threat-models/refactor-queries
branch
from
dad4b1e
to
05f7356
Compare
egregius313
force-pushed
the
egregius313/go/df/threat-models/refactor-queries
branch
from
05f7356
to
bdf36e3
Compare
egregius313
dismissed
owen-mc’s stale review
The merge-base changed after approval.
egregius313
force-pushed
the
egregius313/go/df/threat-models/refactor-queries
branch
from
bdf36e3
to
5bbd003
Compare
igfoo
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #16697. This refactors queries to use
ThreatModelFlowSourceinstead ofRemoteFlowSourcein their definitions ofisSource.Since the Go libraries currently do not have any local sources as far as I can tell, this should not be a breaking change.
Note
Since this PR is based on #16697, the appropriate commit range to review is: https://github.com/github/codeql/pull/16709/files/03aa05c8c19cd9b396a51ee29307aea7c9aaab69..b4d4f8268f123045d5cb46723a883e6e788f082c