Skip to content

Java: Add FileUtils sinks to path injection #16712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 11, 2024
Merged

Java: Add FileUtils sinks to path injection #16712

merged 6 commits into from
Jun 11, 2024

Conversation

mbaluda
Copy link
Contributor

@mbaluda mbaluda commented Jun 10, 2024

Adds more org.apache.commons.io.FileUtils-related sinks to the path injection query.

@mbaluda mbaluda requested a review from a team as a code owner June 10, 2024 09:43
Copy link
Contributor

github-actions bot commented Jun 10, 2024

⚠️ The head of this PR and the base branch were compared for differences in the framework coverage reports. The generated reports are available in the artifacts of this workflow run. The differences will be picked up by the nightly job after the PR gets merged.

Click to show differences in coverage

java

Generated file changes for java

  • Changes to framework-coverage-java.rst:
-    `Apache Commons IO <https://commons.apache.org/proper/commons-io/>`_,``org.apache.commons.io``,,562,118,99,,,,,15
+    `Apache Commons IO <https://commons.apache.org/proper/commons-io/>`_,``org.apache.commons.io``,,562,124,105,,,,,15
-    Totals,,310,25130,2584,353,16,128,33,1,409
+    Totals,,310,25130,2590,359,16,128,33,1,409
  • Changes to framework-coverage-java.csv:
- org.apache.commons.io,118,,562,,,,,,,,,4,,,,,,,,,,,,,,,99,,,,,,,,,15,,,,,,,,,,,,,,,548,14
+ org.apache.commons.io,124,,562,,,,,,,,,4,,,,,,,,,,,,,,,105,,,,,,,,,15,,,,,,,,,,,,,,,548,14

@smowton smowton changed the title Adds FileUtils sinks to path injection Java: Add FileUtils sinks to path injection Jun 10, 2024
mbaluda and others added 2 commits June 11, 2024 12:05
Address reviewiew comments

Co-authored-by: Tony Torralba <atorralba@users.noreply.github.com>
Update provenance in test expectations
@mbaluda mbaluda requested review from atorralba and owen-mc June 11, 2024 14:03
Copy link
Contributor

@atorralba atorralba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mbaluda! I'll merge on green.

@atorralba atorralba merged commit a299afa into github:main Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants