C#/Java: Respect manual neutrals, sources and sinks in model generation. #16722
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelnebel
force-pushed
the
csharp/modelgensourcesink
branch
from
1fd3586 to
f1f8654
Compare
|
|
michaelnebel
force-pushed
the
csharp/modelgensourcesink
branch
from
9623eff to
6da9b73
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
194
to
197
| catch (Exception e) | ||
| { | ||
| ExtractionContext.Logger.LogDebug($"Failed to compute absolute path for relative path in line mapping: '{mappedToPath}': {e}"); | ||
| } |
Check notice
Code scanning / CodeQL
Generic catch clause
Comment on lines
152
to
155
| catch (Exception ex) // lgtm[cs/catch-of-all-exceptions] | ||
| { | ||
| fileLogger.Log(Severity.Error, " Unhandled exception: {0}", ex); | ||
| } |
Check notice
Code scanning / CodeQL
Generic catch clause
michaelnebel
force-pushed
the
csharp/modelgensourcesink
branch
from
6da9b73 to
6e3a5a9
Compare
michaelnebel
force-pushed
the
csharp/modelgensourcesink
branch
2 times, most recently
from
cf6ab3a to
ea065b6
Compare
michaelnebel
force-pushed
the
csharp/modelgensourcesink
branch
from
ea065b6 to
7fb9780
Compare
| @@ -1,72 +1,11 @@ | |||
| private import CaptureModelsSpecific | |||
| private import csharp as CS | |||
Check warning
Code scanning / CodeQL
Names only differing by case
…ation and allow source generation for all source kinds.
michaelnebel
force-pushed
the
csharp/modelgensourcesink
branch
from
a2d4063 to
24685a0
Compare
michaelnebel
changed the title
michaelnebel
added
the
no-change-note-required
|
DCA looks good; Java integration test failure is unrelated to this PR. |
hvitved
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we create separate classes of callables to be used by the dataflow configurations for the source, sink and summary callable target classes for model generation. Furthermore, we
IMO we should also avoid lifting sources or sinks the same way we do for summaries due to the following reason (this will also become easier to implement with the different classes for summary, source and sink callables): Contrary to summaries - sources and sinks have more granular kinds. As an example, we could imagine an interface or abstract class for writing to a stream. Depending on the implementation the stream writer could write to maybe the console, a file, a database, a log, etc. which could all be of different kinds (of sinks). That is, if we are lifting sinks we would then get a union of these kinds and the prototype implementation would become a "universal" sink.