Skip to content

Go: Only log one line for stray .go files #16726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

mbg
Copy link
Member

@mbg mbg commented Jun 11, 2024

This PR improves the logging for stray Go source files to only log one line, rather than one for each stray source file (which can be a lot in repos that don't use Go modules).

@mbg mbg self-assigned this Jun 11, 2024
@mbg mbg requested a review from a team as a code owner June 11, 2024 17:07
@github-actions github-actions bot added the Go label Jun 11, 2024
Copy link
Contributor

@owen-mc owen-mc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic seems good. Have you checked that it works on an example?

@mbg mbg merged commit 202d77d into main Jun 11, 2024
@mbg mbg deleted the mbg/go/log-one-line-for-stray-sources branch June 11, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants