Skip to content

JS: Extract SAP XSJS file types as Javascript #16729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 21, 2024
Merged

JS: Extract SAP XSJS file types as Javascript #16729

merged 3 commits into from
Jun 21, 2024

Conversation

mbaluda
Copy link
Contributor

@mbaluda mbaluda commented Jun 11, 2024

SAP HANA XS uses *.xsjs and *.xsjslib files that are valid Javascript. This PR extracts these file types as Javascript.

@mbaluda mbaluda requested a review from a team as a code owner June 11, 2024 21:54
@github-actions github-actions bot added the JS label Jun 11, 2024
@mbaluda mbaluda changed the title Extract SAP XSJS file types as Javascript JS: Extract SAP XSJS file types as Javascript Jun 11, 2024
Copy link
Contributor

@erik-krogh erik-krogh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable 👍

Your second commit just removes a spurious import you added in the first commit.
But that can be fixed with a squash-merge.

@erik-krogh
Copy link
Contributor

Do you want me to merge it, or can you do that yourself?

@mbaluda
Copy link
Contributor Author

mbaluda commented Jun 21, 2024

@erik-krogh that'd be great! I do not have the rights...

@erik-krogh erik-krogh merged commit 49f74ba into github:main Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants