Skip to content

Conversation

atorralba
Copy link
Contributor

Don't enable Android analysis when only an Android Manifest generated by Swagger Codegen is present.

Don't enable Android analysis when only an Android Manifest generated by Swagger Codegen is present.
@atorralba atorralba requested a review from a team as a code owner June 12, 2024 10:37
@@ -10,12 +10,12 @@
private import semmle.code.java.dataflow.ExternalFlow
private import semmle.code.java.dataflow.FlowSinks
private import semmle.code.java.dataflow.FlowSources
private import semmle.code.java.frameworks.android.Android

Check warning

Code scanning / CodeQL

Redundant import

Redundant import, the module is already imported inside [semmle.code.java.dataflow.FlowSources](1).
Copy link
Contributor

@owen-mc owen-mc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't merge this until I've had a chance to discuss more general solutions with you.

@owen-mc
Copy link
Contributor

owen-mc commented Jul 8, 2024

Closed in favour of #16914

@owen-mc owen-mc closed this Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants