JS: Allow many Array steps to be used in type-tracking #16739
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oh how I have enjoyed working with InlineExpectationTests for these sort of things, not worrying about all the .expected files changing because you add a few lines in the middle of your tests :D
asgerf
reviewed
Jun 18, 2024
javascript/ql/lib/change-notes/2024-06-14-type-tracking-array-steps.md
Outdated
Show resolved
Hide resolved
…steps.md Co-authored-by: Asger F <asgerf@github.com>
asgerf
approved these changes
Jun 20, 2024
asgerf
added a commit
to asgerf/codeql
that referenced
this pull request
Jun 26, 2024
New library gets FN for spread arguments in a call to splice(), which was added to the old version in this PR: github#16739
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also spotted a mistake in Array.splice modeling, so I also fixed it up.
I think the big question is whether we actually want to have these steps part of normal type-tracking; by allowing read of array elements at any position, we might not handle examples like the one below precisely (and think the call
f()could target any of the 3 functions)note: I didn't actually test this out, just thinking out loud