Java: Exclude loopback address from reverse DNS source #16761
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atorralba
reviewed
Jun 14, 2024
Comment on lines
54
to
59
| // GOOD: reverse DNS on loopback address is fine | ||
| if (loopback.getCanonicalHostName().equals("localhost")) { | ||
| login(user, password); // $ hasConditionalBypassTest | ||
| } | ||
| if (Inet4Address.getLoopbackAddress().getCanonicalHostName().equals("localhost")) { | ||
| login(user, password); // $ hasConditionalBypassTest |
There was a problem hiding this comment.
These are GOOD so they shouldn't have an inline expectation, right?
There was a problem hiding this comment.
Oops! I saw your comment in my IDE as I was puzzling over why the tests were failing and it saved me some time realising what I'd done wrong 😆 .
atorralba
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.