Java: Opt-in java/tainted-permissions-check to threat models.
#16772
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelnebel
changed the title
Java/taintedpermissionthreatmodel to threat models.java/tainted-permissions-check to threat models.
owen-mc
reviewed
Jun 17, 2024
java/ql/src/change-notes/2024-06-17-tainted-permissions-check.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Owen Mansel-Chan <62447351+owen-mc@users.noreply.github.com>
aschackmull
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we opt-in the
java/tainted-permissions-checkto threat models.Prior to this change, the query used both
remoteandlocalsources as input. Now the default is to use onlyremotesources (as this the threat models default). However, it is possible to enablelocal(or other) sources by enabling the relevant threat model.Using MRVA on java top-100 for this query we get
DCA looks good; There are no changes to performance or alerts.
It seems that this query doesn't produce an overwhelming number of results in general.