Skip to content

Java: Fix FPs in java/unused-reference-type for JUnit 4-style tests #17101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 31, 2024

Conversation

owen-mc
Copy link
Contributor

@owen-mc owen-mc commented Jul 30, 2024

This query didn't have any tests. I've added some basic ones just to make sure the PR does what it says it does.

@owen-mc owen-mc requested a review from a team as a code owner July 30, 2024 15:00
owen-mc added 3 commits July 30, 2024 16:29
The motivation is test classes in JUnit 4 and 5 are currently FPs for this. They have methods with `@Test`, so this should fix the FPs.
@owen-mc owen-mc force-pushed the java/dead-ref-types-junit-4-5 branch from 04b5918 to 1cb5f35 Compare July 30, 2024 15:29
Copy link
Contributor

@egregius313 egregius313 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@owen-mc owen-mc merged commit 59e22f6 into github:main Jul 31, 2024
18 checks passed
@owen-mc owen-mc deleted the java/dead-ref-types-junit-4-5 branch July 31, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants