Skip to content

Go: Add import path for Gokogiri #17114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 2, 2024

Conversation

owen-mc
Copy link
Contributor

@owen-mc owen-mc commented Aug 1, 2024

It turns out that jbowtie/gokogiri is a fork of moovweb/gokogiri. They are equally popular, so I have named the models file after the original repo. The things that we model are the same in both packages.

@owen-mc owen-mc added the no-change-note-required This PR does not need a change note label Aug 1, 2024
@owen-mc owen-mc requested a review from a team as a code owner August 1, 2024 10:03
@github-actions github-actions bot added the Go label Aug 1, 2024
Copy link
Contributor

github-actions bot commented Aug 1, 2024

⚠️ The head of this PR and the base branch were compared for differences in the framework coverage reports. The generated reports are available in the artifacts of this workflow run. The differences will be picked up by the nightly job after the PR gets merged.

Click to show differences in coverage

go

Generated file changes for go

  • Changes to framework-coverage-go.rst:
+    Others,"``github.com/moovweb/gokogiri/xml``, ``github.com/moovweb/gokogiri/xpath``",,,5
-    Totals,,267,906,109
+    Totals,,267,906,114
  • Changes to framework-coverage-go.csv:
+ github.com/moovweb/gokogiri/xml,4,,,,,,,4,,,
+ github.com/moovweb/gokogiri/xpath,1,,,,,,,1,,,

smowton
smowton previously approved these changes Aug 1, 2024
Copy link
Contributor

@smowton smowton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks plausible

@owen-mc owen-mc changed the title Go: Add import path for gokogiri Go: Add import path for Gokogiri Aug 1, 2024
@owen-mc owen-mc force-pushed the go/gokogiri/update-import-paths branch from 79d6ef6 to 9167057 Compare August 1, 2024 14:22
smowton
smowton previously approved these changes Aug 1, 2024
smowton
smowton previously approved these changes Aug 1, 2024
@owen-mc owen-mc merged commit 4137353 into github:main Aug 2, 2024
13 checks passed
@owen-mc owen-mc deleted the go/gokogiri/update-import-paths branch August 2, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Go no-change-note-required This PR does not need a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants