Update test expectations after extension numbering fix #17139
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbartol
added
depends on internal PR
|
Note that Go test expectations also need to be updated. |
smowton
reviewed
Aug 5, 2024
Yes, but that's the expected behavior. Previously, one of the test-specific models would get the same ID as one of the standard library's models, so when the test output referenced the test-specific model, it accidentally pulled in whatever random standard model had the same ID as well. Now, since each model ID is unique, the hitchhiking standard model doesn't appear in the output at all. |
adityasharad
approved these changes
Aug 5, 2024
|
Ruby fix here: #17156. |
This was referenced Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates test expectations after a CLI fix to ensure that all extension ID values are unique.