Skip to content

Go: Change provenance for MaD models that use package grouping #17157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

owen-mc
Copy link
Contributor

@owen-mc owen-mc commented Aug 6, 2024

For example, the models for Revel use this package grouping:

extensions:
  - addsTo:
      pack: codeql/go-all
      extensible: packageGrouping
    data:
      - ["revel", "github.com/revel/revel"]
      - ["revel", "github.com/robfig/revel"]

With this PR, tests that use model pretty-printing will have this line when printing models

| 1 | Source: group:revel; Controller; true; Params; ; ; ; remote; manual |

instead of these lines

| 1 | Source: github.com/revel/revel; Controller; true; Params; ; ; ; remote; manual |
| 1 | Source: github.com/robfig/revel; Controller; true; Params; ; ; ; remote; manual |

@owen-mc owen-mc added the no-change-note-required This PR does not need a change note label Aug 6, 2024
@github-actions github-actions bot added the Go label Aug 6, 2024
@owen-mc owen-mc marked this pull request as ready for review August 6, 2024 12:49
@owen-mc owen-mc requested a review from a team as a code owner August 6, 2024 12:49
@owen-mc owen-mc merged commit d240951 into github:main Aug 8, 2024
14 checks passed
@owen-mc owen-mc deleted the go/mad/change-provenance-for-package-grouping branch August 8, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Go no-change-note-required This PR does not need a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants