Skip to content

C#: Pretty print models in tests. #17208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 14, 2024

Conversation

michaelnebel
Copy link
Contributor

@michaelnebel michaelnebel commented Aug 13, 2024

In this PR we re-write the C# tests that uses Models as Data to avoid printing the extension ID for the Models as Data row.

@github-actions github-actions bot added the C# label Aug 13, 2024
@michaelnebel michaelnebel force-pushed the csharp/prettyprintmodels branch from 3589282 to c99899c Compare August 13, 2024 11:03
@michaelnebel michaelnebel marked this pull request as ready for review August 13, 2024 11:36
@michaelnebel michaelnebel requested a review from a team as a code owner August 13, 2024 11:36
* @kind test-postprocess
*/

import codeql.dataflow.test.ProvenancePathGraph
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to be rebased now that #17179 has been merged.

@michaelnebel michaelnebel force-pushed the csharp/prettyprintmodels branch from c99899c to c5343fb Compare August 13, 2024 14:10
@michaelnebel michaelnebel requested review from hvitved and removed request for hvitved August 13, 2024 14:38
Copy link
Contributor

@hvitved hvitved left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for doing this!

@michaelnebel michaelnebel merged commit 3425efe into github:main Aug 14, 2024
16 checks passed
@michaelnebel michaelnebel deleted the csharp/prettyprintmodels branch August 14, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants