C#: Change random temp folder names to hash values #17257
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tamasvajk
commented
Aug 19, 2024
csharp/extractor/Semmle.Extraction.CSharp.DependencyFetching/NugetPackageRestorer.cs
Show resolved
Hide resolved
tamasvajk
force-pushed
the
buildless/temp-locations
branch
from
c7ac3c8 to
d423d30
Compare
tamasvajk
force-pushed
the
buildless/temp-locations
branch
from
d423d30 to
0037ad4
Compare
tamasvajk
force-pushed
the
buildless/temp-locations
branch
from
9d3e1d3 to
07a5c20
Compare
michaelnebel
approved these changes
Aug 21, 2024
...ndencyFetching/SourceGenerators/DotnetSourceGeneratorWrapper/DotnetSourceGeneratorWrapper.cs
Show resolved
Hide resolved
| public static string ComputeHash(string input) | ||
| { | ||
| var bytes = Encoding.Unicode.GetBytes(input); | ||
| var sha = MD5.HashData(bytes); // MD5 to keep it shorter than SHA256 |
There was a problem hiding this comment.
I tried calculating the propability of collision for 1k elements on a 128bit hash - the calculator rounded it to 0 😂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were using
Guid.NewGuid().ToString("N")to generate random file and folder names in source generation. This PR changes that to use a hash value instead. This should make theSuccessfully extracted filesdiff in DCA stable for buildless projects.Integration tests failed after the first commit. It turned out that the tests are executed in temp folders, so hashing absolute paths in tests always resulted in different hash values. I fixed this issue in the subsequent commits.