Java/C++/C#: Provide path-node locations via hasLocationInfo, not getLocation.
#1729
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aschackmull
previously approved these changes
Aug 12, 2019
|
@hvitved: It turns out the C# library uses |
It appears that this is the only place where it was used, and I don't mind the change from your last commit. |
|
@hvitved / @aschackmull, could you re-approve (or merge straight away)? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed, this is slightly more flexible and would make my life a little easier in reusing the shared library (though I could work around it in other ways if this change is considered too disruptive). It also eliminates the only uses of
DataFlowLocation, but I'm fine with keeping it around for potential future uses.cc @hvitved, @jbj, @dave-bartolomeo