C++: Add support for more clang builtins #17311
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jketema
added
the
depends on internal PR
jketema
force-pushed
the
builtins
branch
3 times, most recently
from
21a741a to
08afe5d
Compare
calumgrant
suggested changes
Aug 28, 2024
| /** Gets the contained expression. */ | ||
| Expr getExprOperand() { result = this.getChild(0) } | ||
|
|
||
| override string toString() { result = "sizeof(<expr>)" } |
There was a problem hiding this comment.
I think this should be __datasizeof
There was a problem hiding this comment.
Fixed. A bit too much copy&paste.
| /** Gets the contained type. */ | ||
| Type getTypeOperand() { sizeof_bind(underlyingElement(this), unresolveElement(result)) } | ||
|
|
||
| override string toString() { result = "sizeof(" + this.getTypeOperand().getName() + ")" } |
| * A C++ `__datasizeof` expression (used by some implementations | ||
| * of the `<type_traits>` header). | ||
| * | ||
| * The `__datasizeof` expression behaves identical to `sizeof` except |
| @@ -0,0 +1,10 @@ | |||
| import cpp | |||
|
|
|||
| from DatasizeofOperator sto, string elemDesc, Element e | |||
There was a problem hiding this comment.
Question: Would it be helpful to also output the constant value of the expression?
There was a problem hiding this comment.
Added. Also for the sizeof test from which this was copied.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.