Skip to content

Swift: Move all integration tests. #17324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 28, 2024
Merged

Conversation

criemen
Copy link
Collaborator

@criemen criemen commented Aug 28, 2024

We are no longer bound to the platform-specific directories, so simplify the test organization.
If you don't want this change, just skip merging this PR. It's purely optional.

We are no longer bound to the platform-specific directories,
so simplify the test organization.
If you don't want this change, just skip merging this PR. It's purely optional.
@github-actions github-actions bot added the Swift label Aug 28, 2024
@criemen criemen marked this pull request as ready for review August 28, 2024 09:19
@criemen criemen requested a review from a team as a code owner August 28, 2024 09:19
@geoffw0
Copy link
Contributor

geoffw0 commented Aug 28, 2024

The checks are passing, the new locations look cleaner to me, but I don't usually work with the integration tests.

@redsun82 do you have any objections to this?

Copy link
Contributor

@redsun82 redsun82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better, thanks!

@criemen criemen merged commit 047a655 into main Aug 28, 2024
19 checks passed
@criemen criemen deleted the criemen/move-swift-int-tests branch August 28, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants