Java/C#: Field based model generator (Experimental). #17330
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
michaelnebel
force-pushed
the
java/modelgenfieldbased
branch
2 times, most recently
from
6b21f84 to
ddf3066
Compare
michaelnebel
force-pushed
the
java/modelgenfieldbased
branch
2 times, most recently
from
2a94828 to
9cd176a
Compare
michaelnebel
added
the
no-change-note-required
michaelnebel
force-pushed
the
java/modelgenfieldbased
branch
from
9cd176a to
7bf7df2
Compare
hvitved
previously approved these changes
Sep 5, 2024
|
|
||
| private module PropagateContentFlow = ContentDataFlow::Global<PropagateContentFlowConfig>; | ||
|
|
||
| private string printStoreAccessPath(PropagateContentFlow::AccessPath ap) { |
There was a problem hiding this comment.
nit: Using concat is better (for the same reason that using string builders is better than doing string concatenations). One would then need to define a predicate string getContent(PropagateContentFlow::AccessPath ap, int i).
| ) | ||
| } | ||
|
|
||
| private string printReadAccessPath(PropagateContentFlow::AccessPath ap) { |
tamasvajk
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we introduce a new model generator query for Java and C#. The work is based on #8667.
This should not in any way be considered the final version of these queries.