C#: Extract assignments for field/property initializers #1741
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hvitved
force-pushed
the
csharp/extract-field-inits
branch
from
cc04267 to
495e5bc
Compare
calumgrant
reviewed
Aug 16, 2019
There was a problem hiding this comment.
Overall, I like this change, because these additional expressions could form part of the control flow graph of the constructor. However, we don't need to do this here - I've created a ticket for this instead: https://jira.semmle.com/browse/ODASA-8050
| Expr e; | ||
|
|
||
| InitializerDefinition() { this = TInitializer(a, e) } | ||
| InitializerDefinition() { this.getAssignment().getParent() = fieldOrProp} |
calumgrant
approved these changes
Aug 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small extractor extension in preparation for data-flow through fields.