Skip to content

C#: Extract attributes on indexers. #17475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 16, 2024
Merged

C#: Extract attributes on indexers. #17475

merged 5 commits into from
Sep 16, 2024

Conversation

michaelnebel
Copy link
Contributor

@michaelnebel michaelnebel commented Sep 16, 2024 •
edited
Loading

In this PR we add extractor support for attributes on indexers.
With this change we now extract the attribute usage on the example below

[Attribute]
public object this[int i] => return null;

@michaelnebel michaelnebel changed the title Csharp/indexerattributes C#: Extract attributes on indexers. Sep 16, 2024
@michaelnebel michaelnebel marked this pull request as ready for review September 16, 2024 09:50
@michaelnebel michaelnebel requested a review from a team as a code owner September 16, 2024 09:50
@michaelnebel
Copy link
Contributor Author

DCA looks good!

@michaelnebel michaelnebel merged commit add0332 into github:main Sep 16, 2024
20 checks passed
@michaelnebel michaelnebel deleted the csharp/indexerattributes branch September 16, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hvitved hvitved hvitved approved these changes

+1 more reviewer

@tamasvajk tamasvajk tamasvajk approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
C# documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michaelnebel @hvitved @tamasvajk