Skip to content

Conversation

hvitved
Copy link
Contributor

@hvitved hvitved commented Sep 16, 2024

It is best-practice to have internal logic in an explicit internal folder.

@github-actions github-actions bot added the Rust Pull requests that update Rust code label Sep 16, 2024
@hvitved hvitved force-pushed the rust/generated-internal branch from e6e9b29 to efa52ac Compare September 17, 2024 06:51
@hvitved hvitved marked this pull request as ready for review September 17, 2024 06:59
Copy link
Contributor

@redsun82 redsun82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks!

I'm guessing you want to move the stubs as well in internal (or maybe internal/impl) with another PR?

@hvitved
Copy link
Contributor Author

hvitved commented Sep 17, 2024

I'm guessing you want to move the stubs as well in internal (or maybe internal/impl) with another PR?

Yes, I'll do that in a separate PR, as that affects both Rust and Swift.

@hvitved hvitved merged commit 6618906 into github:main Sep 17, 2024
15 checks passed
@hvitved hvitved deleted the rust/generated-internal branch September 17, 2024 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Rust Pull requests that update Rust code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants