Java: Fix support for variable capture inside object initializers. #17490
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aschackmull
added
the
no-change-note-required
smowton
reviewed
Sep 17, 2024
| @@ -585,11 +585,13 @@ module Flow<LocationSig Location, InputSig<Location> Input> implements OutputSig | |||
| 2 <= strictcount(CapturedVariable v | captureAccess(v, c)) | |||
| or | |||
| // Constructors that capture a variable may assign it to a field, which also | |||
| // entails a this-to-this summary. | |||
| captureAccess(_, c) and c.isConstructor() | |||
| // entails a this-to-this summary. If there are multiple constructors, then | |||
There was a problem hiding this comment.
Do we have a test case for the one-constructor-calls-another case you describe?
| @@ -248,4 +248,15 @@ void run() { | |||
| sink(l.get(0)); // $ hasValueFlow=src | |||
| sink(l2.get(0)); // $ hasValueFlow=src | |||
| } | |||
|
|
|||
| void testInstanceInitializer() { | |||
| String s = source("init"); | |||
There was a problem hiding this comment.
Add a comment noting that this is exercising specifically the obinit routine propagating taint?
smowton
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Variable capture in constructors was only supported when the constructor was called directly - if the capture happened a call away, e.g. in the object initializer, which is a common pattern, then we failed to recognize it.
Fixes #17473