Python: Expand StringConstCompareBarrier sanitizer gaurds to cover additional constants
#17540
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoff
reviewed
Sep 23, 2024
| @@ -142,7 +142,7 @@ module UrlRedirect { | |||
| /** | |||
| * A comparison with a constant string, considered as a sanitizer-guard. | |||
| */ | |||
| class StringConstCompareAsSanitizerGuard extends Sanitizer, StringConstCompareBarrier { | |||
| class StringConstCompareAsSanitizerGuard extends Sanitizer, ConstCompareBarrier { | |||
There was a problem hiding this comment.
Did you mean to follow the same pattern of deprecation here?
There was a problem hiding this comment.
Yes; I had missed it with a find-and-replace.
Updated.
yoff
reviewed
Sep 23, 2024
|
|
||
| def test_in_list_with_constants(): | ||
| ts = TAINTED_STRING | ||
| if ts in ["safe", None, 3, False]: |
There was a problem hiding this comment.
Would it be considered tainted if there is a non-constant in this list? Should we have a test with that?
There was a problem hiding this comment.
Additional test added.
|
This looks like a very nice and useful generalisation :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renames
StringConstCompareBarriertoConstCompareBarrierand expands it to cover comparisons to additional constats such asNone.This reduces FP flow in cases such as
if x is None: return x.