Rust: Enable CFG consistency checks #17558
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -0,0 +1,33 @@ | |||
| private import codeql.rust.elements.Expr | |||
Check warning
Code scanning / CodeQL
Redundant import Warning
hvitved
force-pushed
the
rust/cfg-consistency-queries
branch
from
16c74aa to
0b0b87e
Compare
hvitved
force-pushed
the
rust/cfg-consistency-queries
branch
from
0b0b87e to
cbc2389
Compare
| @@ -22,5 +21,7 @@ module Impl { | |||
| * x += y; | |||
| * ``` | |||
| */ | |||
| class BinaryExpr extends Generated::BinaryExpr { } | |||
| class BinaryExpr extends Generated::BinaryExpr { | |||
| override string toString() { result = "... " + this.getOperatorName() + " ..." } | |||
There was a problem hiding this comment.
We should perhaps allow specifying a toString implementation in the schema so they can be generated.
There was a problem hiding this comment.
How is that easier than doing it here?
There was a problem hiding this comment.
Instead of editing many files, you can do it all in one file. We may even be able to generate pretty sensible default toString implementations from the rust.ungram file.
There was a problem hiding this comment.
Sensible default toStrings would be nice. However, I think this would be the right place to override them; this is also where one would add additional predicates.
| @@ -73,7 +73,7 @@ class BecomeExprTree extends StandardPostOrderTree instanceof BecomeExpr { | |||
| } | |||
|
|
|||
| class BinaryOpExprTree extends StandardPostOrderTree instanceof BinaryExpr { | |||
| BinaryOpExprTree() { super.getOperatorName() != "&&" and super.getOperatorName() != "||" } | |||
| BinaryOpExprTree() { not this instanceof LogicalOrExpr and not this instanceof LogicalAndExpr } | |||
There was a problem hiding this comment.
This would be slightly shorter, not sure if it is better though.
| BinaryOpExprTree() { not this instanceof LogicalOrExpr and not this instanceof LogicalAndExpr } | |
| BinaryOpExprTree() { not this instanceof LogicalOperation } |
| query predicate nonPostOrderExpr(Expr e, string cls) { | ||
| cls = e.getPrimaryQlClasses() and | ||
| not e instanceof LetExpr and | ||
| not e instanceof LogicalAndExpr and // todo |
There was a problem hiding this comment.
What about LogicalNotExpr ?
There was a problem hiding this comment.
Not yet modeled in the CFG.
| @@ -22,5 +21,7 @@ module Impl { | |||
| * x += y; | |||
| * ``` | |||
| */ | |||
| class BinaryExpr extends Generated::BinaryExpr { } | |||
| class BinaryExpr extends Generated::BinaryExpr { | |||
| override string toString() { result = "... " + this.getOperatorName() + " ..." } | |||
There was a problem hiding this comment.
Instead of editing many files, you can do it all in one file. We may even be able to generate pretty sensible default toString implementations from the rust.ungram file.
Commit-by-commit review suggested.