Skip to content

Conversation

aschackmull
Copy link
Contributor

Looking through the data from my initial MRVA top 100 speculative taint run, these additional types came up as potentially relevant to sanitize. The temporals I've also seen pop up before. This should help guard against FP flow going too much off the rails.

I'll run dca before phrasing the change note.

@aschackmull aschackmull requested a review from a team as a code owner September 25, 2024 08:45
@github-actions github-actions bot added the Java label Sep 25, 2024
@aschackmull
Copy link
Contributor Author

I'll run dca before phrasing the change note.

No actual alert differences in dca. I think we can skip the change note then.

@aschackmull aschackmull added the no-change-note-required This PR does not need a change note label Sep 25, 2024
@owen-mc
Copy link
Contributor

owen-mc commented Sep 25, 2024

It might be worth running QA, as this might have an effect in a more obscure case than the default DCA suite covers.

@aschackmull
Copy link
Contributor Author

It might be worth running QA, as this might have an effect in a more obscure case than the default DCA suite covers.

For what purpose? To determine that we need a change note after all? Or to find a few cases of FPs, which we now filter. I think that's a bit overkill.

@owen-mc
Copy link
Contributor

owen-mc commented Sep 25, 2024

If you're sure there definitely won't be any TPs that we lose, then there is no need to run QA.

@aschackmull
Copy link
Contributor Author

If you're sure there definitely won't be any TPs that we lose, then there is no need to run QA.

I'm pretty sure. Famous last words and all that, but really, if I see a flow path through one of these types, then that will generally be enough for me to deem it to be clearly FP flow.

@aschackmull aschackmull merged commit a017f92 into github:main Sep 30, 2024
14 of 15 checks passed
@aschackmull aschackmull deleted the java/type-sanitizers branch September 30, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Java no-change-note-required This PR does not need a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants