Skip to content

Rust: Repair rust/diagnostics/unextracted-elements #17589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 26, 2024

Conversation

geoffw0
Copy link
Contributor

@geoffw0 geoffw0 commented Sep 25, 2024

Repair rust/diagnostics/unextracted-elements. The new version of this query has limited value because (1) Unextracted do not have a Location available any more and (2) neither the test nor any snapshot I've tried actually has an Unextracted elements. Nevertheless having this does mean we have some visibility if (2) ever changes.

@aibaars

@geoffw0 geoffw0 added the Rust Pull requests that update Rust code label Sep 25, 2024
@aibaars
Copy link
Contributor

aibaars commented Sep 26, 2024

This query looks fine to me, however, there won't be any Unextracted elements in any database at the moment.

@geoffw0 geoffw0 merged commit 7b39608 into github:main Sep 26, 2024
14 checks passed
@geoffw0 geoffw0 deleted the missing2 branch October 29, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Rust Pull requests that update Rust code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants