-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Java/C#: Add overrides to the interpretation of neutral MaD models. #17604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Would you also be up to making the same change for C# as a part of this PR to align the semantics of C# and Java? (if you prefer I can make the corresponding PR for C# instead). |
ddffa3f
to
689bc21
Compare
689bc21
to
0459d13
Compare
Done. And I've fixed the Java tests. What about the failing C# test? Accept the test changes? I haven't tried to dig into exactly what that test does. |
Yes, you can accept the updated test output: In this case the updated rows are callables targeted by the neutral MaD rows. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me - but maybe also run DCA.
That seems a bit like potential overkill - neutrals really shouldn't have much effect on analysis, but I guess there is a small chance of impact. I'll kick off a pair of runs. |
Dca was fairly uneventful - mostly just telemetry changes, which makes sense. |
Neutrals generally have little impact on the analysis, but having a neutral like
Map.containsKey
also coverHashMap.containsKey
makes a lot of sense. This might remove a tiny bit of source dispatch for low-confidence dispatch to source implementations of such methods, as that's AFAIR the only touchpoint between neutrals and analysis semantics.