Java: Minor model tweak and comment fix. #17625
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The remove methods should not have been in this section, as they're plain neutrals.
aschackmull
added
the
no-change-note-required
aschackmull
force-pushed
the
java/collection-neutrals
branch
from
a6b2ba5 to
222ae6a
Compare
smowton
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The comment about
WithoutElementin relation to theremovemethods was wrong, so fix that. Also, a couple of very small actual tweaks in relation to that:Set.clearshould apply to overrides, and add neutrals forCollection.removeandComparable.compareTo.